fix(ListBox): add component and fix other docs #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 244a714 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for cube-uikit-docs failed.
|
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-b1c8394. |
Contributor
🏗 Docs are successfully deployed!👀 Preview: https://685e90d7b325fb83a35db31c--cube-uikit-docs.netlify.app |
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several styling inconsistencies and updates component documentation and story organization, while also introducing the new ListBox component.
- Update disabled color for MenuButton and story title for Menu.
- Enhance Select component styling and expand its story configuration.
- Add a new ListBox component with comprehensive search, filtering, and grouping functionality, along with corresponding stories and documentation.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/pickers/Menu/MenuButton.tsx | Updated disabled color from '#dark.04' to '#clear' to match design. |
| src/components/pickers/Menu/Menu.stories.tsx | Changed story title to 'Actions/Menu' for clearer categorization. |
| src/components/fields/index.ts | Exported the new ListBox component. |
| src/components/fields/Select/Select.tsx | Adjusted color and fill schemes in options styling. |
| src/components/fields/Select/Select.stories.tsx | Expanded prop definitions and updated story args. |
| src/components/fields/ListBox.tsx | Introduced the new ListBox component with search, filtering, and grouping. |
| src/components/fields/ListBox.stories.tsx | Added various usage stories for ListBox functionality. |
| src/components/fields/ListBox.docs.mdx | Documented the new ListBox component along with usage examples. |
| src/components/fields/ComboBox/ComboBox.stories.tsx | Updated story title for improved consistency. |
Comments suppressed due to low confidence (3)
src/components/pickers/Menu/Menu.stories.tsx:27
- [nitpick] Ensure that the updated story title 'Actions/Menu' aligns with the intended categorization across documentation and story grouping.
title: 'Actions/Menu',
src/components/fields/ListBox.tsx:284
- [nitpick] Consider adding tests to cover the filtering logic in the ListBox, especially for scenarios dealing with complex or non-string child elements to ensure robust behavior.
const filteredChildren = useMemo(() => {
src/components/pickers/Menu/MenuButton.tsx:27
- Confirm that changing the disabled color to '#clear' is intentional and consistent with the design specifications. Verify if similar updates are needed in other components to maintain visual consistency.
disabled: '#clear',
tenphi
had a problem deploying
to
Canary package in NPM
GitHub Actions
Failure
tenphi
had a problem deploying
to
Canary package in NPM
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.